Skip to content

[DO NOT MERGE] only pin down numpy==2.2.1 and pandas==2.2.3 for 2.62.0#33627

Closed
liferoad wants to merge 4 commits intoapache:release-2.62.0from
liferoad:release-2.62.0-numpy-update
Closed

[DO NOT MERGE] only pin down numpy==2.2.1 and pandas==2.2.3 for 2.62.0#33627
liferoad wants to merge 4 commits intoapache:release-2.62.0from
liferoad:release-2.62.0-numpy-update

Conversation

@liferoad
Copy link
Contributor

@liferoad liferoad commented Jan 16, 2025 •
edited
Loading

pin numpy==2.0.2 for Python 3.9. Others use numpy==2.2.1.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@liferoad liferoad changed the title [DO NOT MERGE] only pin down numpy==2.2.1 [DO NOT MERGE] only pin down numpy==2.2.1 for 2.62.0 Jan 16, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jan 17, 2025

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @damccorm for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@liferoad liferoad changed the title [DO NOT MERGE] only pin down numpy==2.2.1 for 2.62.0 [DO NOT MERGE] only pin down numpy==2.2.1 and pandas==2.2.3 for 2.62.0 Jan 17, 2025
@liferoad liferoad requested a review from tvalentyn January 17, 2025 00:42
@liferoad
Copy link
Contributor Author

liferoad commented Jan 17, 2025

ERROR: No matching distribution found for numpy==2.2.1 for python 3.9:
image

@tvalentyn
Copy link
Contributor

tvalentyn commented Jan 17, 2025

I would merge something similar on main, but not not on release branch

@tvalentyn
Copy link
Contributor

tvalentyn commented Jan 17, 2025

question is, why numpy is not bumped up. need to create a docker container instance from a released container and run pipdeptree

@tvalentyn
Copy link
Contributor

tvalentyn commented Jan 17, 2025

It's from:

pandas==2.1.4
├── numpy [required: >=1.22.4,<2, installed: 1.26.4]

@liferoad liferoad mentioned this pull request Jan 17, 2025
Closed
17 tasks
@liferoad
Copy link
Contributor Author

liferoad commented Jan 17, 2025

It's from:

pandas==2.1.4
├── numpy [required: >=1.22.4,<2, installed: 1.26.4]

https://github.com/apache/beam/blob/master/sdks/python/setup.py#L411

this causes pandas stays with 2.1.4

@liferoad
Copy link
Contributor Author

liferoad commented Jan 17, 2025

PreCommit Flink Container / beam_PreCommit_Flink_Container (Run Flink Container PreCommit) (pull_request_target) Failing after 24m: this has been failing on the release branch since the beginning.

@liferoad
Copy link
Contributor Author

liferoad commented Jan 17, 2025

decided to fix this with 2.63.0.

@liferoad liferoad closed this Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tvalentyn tvalentyn Awaiting requested review from tvalentyn

Assignees

No one assigned

Labels

docker Next Action: Reviewers python

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@liferoad @tvalentyn